Skip to content
Snippets Groups Projects
  1. Nov 05, 2024
  2. Sep 23, 2024
  3. Aug 06, 2024
    • STEVAN Antoine's avatar
      refactor algebra module (dragoon/komodo!165) · 8c07220b
      STEVAN Antoine authored
      `algebra`, `field` and `linalg` were doing extremely similar things before...
      
      this MR merges them into a single module `algebra`
      - old `algebra` and `field` are at the root of the new `algebra`
      - old `linalg` is now `algebra::linalg`
      
      all references to these have been fixed in the rest of the codebase and the features have been tuned to work fine.
      8c07220b
  4. Aug 01, 2024
    • STEVAN Antoine's avatar
      refactor repo architecture (!161) · 3608e95a
      STEVAN Antoine authored
      ## changelog
      - `src/main.rs` has been moved to a new crate: `bins/saclin` which stands for **S**emi-**A**VID **CLI** in **N**ushell
      - dependencies of `komodo` have been fixed
      - Nushell and Rust tests have been split in the Makefile: by default, only Rust tests will run locally and Nushell tests and examples can be run manually if desired. The CI will still run everything.
      - the README has been updated
      - test images have been moved to `assets/`
      - the majority of the old `./nu-utils/` module have been moved to internals of `./benchmarks/` and imports have been fixed
      - `cargo.nu` has been moved to `./bins/` and a new `./bins/README.md` mentions it
      - `./bins/saclin/` has been created and should be a self-contained Rust crate + Nushell module
      3608e95a
  5. Jun 07, 2024
  6. Jun 06, 2024
  7. Jun 05, 2024
  8. Jun 03, 2024
  9. May 31, 2024
    • STEVAN Antoine's avatar
      make `inbreeding watch` better and more robust (!136) · e841c66b
      STEVAN Antoine authored
      - early return when format is bad twice
      - refactor
      e841c66b
    • STEVAN Antoine's avatar
      add `inbreeding list` (!135) · 3f4c8ddb
      STEVAN Antoine authored
      wait for
      - !134 
      
      ## description
      assuming !134 has been merged, this MR allows to run something like
      ```bash
      inbreeding list | input list --fuzzy | inbreeding load $in | inbreeding plot
      ```
      which will fuzzy find the available experiments and then plot it after load 👌
      3f4c8ddb
    • STEVAN Antoine's avatar
      add information about experiment to `inbreeding load` (!134) · 142e673e
      STEVAN Antoine authored
      this can be used by `plot` without passing extra arguments, i.e. the pipeline becomes
      ```bash
      use bins/inbreeding
      
      let experiment = "..."
      ```
      ```bash
      inbreeding load $experiment | inbreeding plot
      ```
      instead of having to know the value of `k` and do
      ```bash
      inbreeding load $experiment | inbreeding plot --options { k: $k }
      ```
      142e673e
    • STEVAN Antoine's avatar
      branch out RNG when measuring (!130) · a3a5f2e2
      STEVAN Antoine authored
      - addresses #9 
      - needed !133 to work
      
      this MR simply adds `+ Clone` to `rng` and removes the `mut` from the `rng` of the `measure_inbreeding` function.
      
      running the same snippet of code from #9 yields the following two images with a schedule of $1$ and $5$ respectively
      
      ![000_1.1](/uploads/ace74e299c6d4374df713ab5004f3c1d/000_1.1.png)
      ![000_1.2](/uploads/c784f5b62c41004971fd3048f7b5babc/000_1.2.png)
      
      we see that all measurements on $t$ where $t = 0 \mod 5$ are the same in both images 🎉
      a3a5f2e2
  10. May 30, 2024
    • STEVAN Antoine's avatar
      fix experiment hash by not hashing _measurement schedule_ (!133) · 3b26bad1
      STEVAN Antoine authored
      related to
      - #9
      
      in order for the measurements not to influence the experiment, the seeds passed to the runs need to not include the _measurement schedule_ parameters!
      
      EDIT: in the end, it's more than that, we want to only include things related to the environment in its hash, nothing related to the measurements, i.e. we want to either
      - exclude `strategies`, `nb_scenarii`, `measurement_schedule`, `measurement_schedule_start`, `nb_measurements` and `max_t`
      - include `nb_bytes`, `k`, `n` and `environment`
      3b26bad1
    • STEVAN Antoine's avatar
      and `inbreeding watch` command (!131) · a58c650a
      STEVAN Antoine authored
      ## output sample
      let's say the current seed is `"b239e48345ac457b492cc164f58c010d07292c88e4791e607d91796baec7f334"` and the experiment has ID `fixed:0-single:3-5-50-10240`, and that we are watching both the creation of the first experiment and a few runs, e.g.
      - `002d8de28913efbf7dbd111b817ae901fee2d47882ba7aa76d293c2d95d9652c`
      - `015672b37c9cf1a6b475937987294f9a503a922ffbcfdfc5d18ef839fac91b8c`
      - `080a51a17ac43fcbdf08f77f3bc993983fef589bd9672f04382af4b16dd09b13`
      
      then the output would look like
      ```
      b239e48  fixed:0-single:3-5-50-10240            at 2024-05-30 15:24:12
      b239e48  fixed:0-single:3-5-50-10240  002d8de   at 2024-05-30 15:24:14
      b239e48  fixed:0-single:3-5-50-10240  015672b   at 2024-05-30 15:24:16
      b239e48  fixed:0-single:3-5-50-10240  080a51a   at 2024-05-30 15:24:18
      ```
      a58c650a
    • STEVAN Antoine's avatar
      remove all mentions to "naive" and "true" recoding (dragoon/komodo!132) · 71410d6f
      STEVAN Antoine authored
      we are switching
      - _naive recoding_ to _$(k, 1)$-re-encoding_
      - _true recoding_ to _$k$-recoding_
      71410d6f
    • STEVAN Antoine's avatar
      hash the whole experiment and remove timestamp (dragoon/komodo!129) · e38dcb17
      STEVAN Antoine authored
      this is to have a complete identifier for each run, which does not depend at all on the time at which the experiment runs.
      e38dcb17
    • STEVAN Antoine's avatar
      fix random item draw (!127) · e5311d6c
      STEVAN Antoine authored
      related to
      - !122
      
      ## description
      !122 introduced a `draw_unique_indices` function which uses a `HashSet` to accumulate unique indices in the range `0..<len`.
      however, a `HashSet` does not preserve the order of insertion when iterating over the elements of the set... which results in apparent randomness, even though the RNG seed is the same 😮 
      
      this MR switches back to using `shuffle` which used to work, even though a bit less performant 👌   
      it's basically a revert of !122, while keeping the refactoring into `random.rs`.
      
      ## measuring the performance
      i did run the same timing experiment from !122 but with `main` on `bb55005f` and the MR on `fix-shuffle`
      
      | env     | main                   | mr                      | improvement         |
      | ------- | ---------------------- | ----------------------- | ------------------- |
      | fixed:0 | 6sec 244ms 238µs 45ns | 8sec 734ms 929µs 328ns | -39.88783363238997  |
      | fixed:1 | 639ms 720µs 39ns      | 731ms 360µs 261ns      | -14.325051024390373 |
      
      we loose a bit
      e5311d6c
    • STEVAN Antoine's avatar
      support proper 32-byte RNG seeds (dragoon/komodo!126) · bb55005f
      STEVAN Antoine authored
      - add optional `$.help` to argument `err` of `error throw`
      - parse `prng_seed: [u8; 32]` in `rng` and `inbreeding`
      - compute the "_local_" seed by hashing the "_global_" seed, the strategy and the iteration index
      - pass `--prng-seed: string`, a 64-char long seed to `inbreeding run`
      bb55005f
  11. May 29, 2024
    • STEVAN Antoine's avatar
      parse experiment names with regex (!128) · 3b4d14d1
      STEVAN Antoine authored
      because the "_environment_" can contain an experiment separator, e.g. `random-fixed`, more powerful `parse` patterns needs to be used.
      3b4d14d1
    • STEVAN Antoine's avatar
      add `inbreeding inspect` to look at the cache (!125) · 0b51ce48
      STEVAN Antoine authored
      * 7b44a886 refactor constants from `inbreeding load`
      * 64e446f7 move `remove-cache-prefix` to new `path.nu`
      * 822b03fd add `inbreeding inspect`
      0b51ce48
    • STEVAN Antoine's avatar
      complete experiment dump paths with k, n, ... (!124) · 85f60a29
      STEVAN Antoine authored
      in order to add more information in the experiment names, e.g. $k$, $n$ and $\#\text{bytes}$, this MR changes the cache files format from
      ```
      {seed}/{timestamp}/{env}/{strategy}/...
      ```
      to
      ```
      {seed}/{timestamp}-{env}-{strategy}-{k}-{n}-{nb_bytes}/...
      ```
      85f60a29
    • STEVAN Antoine's avatar
      make `.nushell/` a proper module (dragoon/komodo!123) · 45540a7c
      STEVAN Antoine authored
      this MR turns `./.nushell/` into a directory module by
      - adding `mod.nu`
      - exporting all the modules
      
      all uses of `.nushell/` have been fixed to not mention `.nu` internal modules anymore.
      
      > 💡 **Note**  
      > the `.nushell venv` module has been removed because, when the `$venv.VENV` activation script is not there, Nushell can't parse the whole `.nushell` module, which is very annoying to have to rely of the state of the external filesystem to be able to simply parse a module...
      45540a7c
    • STEVAN Antoine's avatar
    • STEVAN Antoine's avatar
      improve performances by not shuffling vectors (dragoon/komodo!122) · 47ba0de8
      STEVAN Antoine authored
      in `./bins/inbreeding/`, this MR does
      - refactor the "list item drawing" from `environment.rs` and `strategy.rs` into the `draw_unique_elements` function of new `random.rs` module
      - use a `HashSet` to draw unique indices in the slice of "things" to draw from and then extracts the items corresponding to these indices
      
      ## results
      ```bash
      use ./bins/inbreeding
      use std bench
      
      const PRNG_SEED = 0
      const OPTS = {
          nb_bytes: (10 * 1_024),
          k: 10,
          n: 20,
          nb_measurements: 100,
          nb_scenarii: 10,
          measurement_schedule: 1,
          measurement_schedule_start: 2_000,
          max_t: 2_000,
          strategies: [ "single:5" ],
          environment: null,
      }
      
      def run [rev: string] {
          git co $rev
      
          inbreeding build
      
          let a = bench --rounds 5 {
              inbreeding run --options ($OPTS | update environment "fixed:0") --prng-seed $PRNG_SEED
          }
          let b = bench --rounds 5 {
              inbreeding run --options ($OPTS | update environment "fixed:1") --prng-seed $PRNG_SEED
          }
      
          {
              0: $a,
              1: $b,
          }
      }
      
      let main = run a29b511d
      let mr = run fix-shuffle
      ```
      ```bash
      let table = [
          [env, main, mr, improvement];
      
          ["fixed:0", $main."0".mean, $mr."0".mean, (($main."0".mean - $mr."0".mean) / $main."0".mean * 100)],
          ["fixed:1", $main."1".mean, $mr."1".mean, (($main."1".mean - $mr."1".mean) / $main."1".mean * 100)],
      ]
      
      $table | to md --pretty
      ```
      
      | env     | main                    | mr                      | improvement        |
      | ------- | ----------------------- | ----------------------- | ------------------ |
      | fixed:0 | 8sec 504ms 794µs 784ns | 6sec 353ms 206µs 645ns | 25.298530930431912 |
      | fixed:1 | 727ms 648µs 292ns      | 639ms 443µs 782ns      | 12.12186037811795  |
      
      the improvement is quite nice, even though not huge, but the code is cleaner anyways 🙏
      47ba0de8
  12. May 28, 2024
    • STEVAN Antoine's avatar
      include the standard deviation of "inbreeding" measurements (!119) · a29b511d
      STEVAN Antoine authored
      this adds `$.diversity.e` to the output of `inbreeding load` and input of `inbreeding plot` to show errors bars in the final plot.
      
      these can be discarded by running something similar to
      ```bash
      inbreeding load $experiment
          | reject diversity.e
          | inbreeding plot --options { k: $OPTS.k }
      ```
      a29b511d
    • STEVAN Antoine's avatar
      split "inbreeding" load and plot (dragoon/komodo!118) · 31d58f4c
      STEVAN Antoine authored
      plotting "inbreeding" results is now done in two steps
      - `load` the data from raw experiment files with `inbreeding load`
      - `plot` the results by piping this data into `inbreeding plot`
      31d58f4c
    • STEVAN Antoine's avatar
      split `examples/` into `benchmarks/` and `bins/` (dragoon/komodo!117) · bb626120
      STEVAN Antoine authored
      ## new structure for the repository
      - benchmarks are in `./benchmarks/` and can be run with either `cargo run --package benchmarks --bin <bench>` or the commands in `./benchmarks/README.md`
      ```
      ├── Cargo.toml
      ├── README.md
      └── src
          └── bin
              ├── commit.rs
              ├── fec.rs
              ├── linalg.rs
              ├── operations
              │   ├── curve_group.rs
              │   └── field.rs
              ├── recoding.rs
              ├── setup.rs
              └── setup_size.rs
      ```
      
      - examples are now in `./bins/` as standalone binaries and can be run either with `cargo run --package <pkg>` or with the help of the `cargo bin` command from `.nushell/cargo.nu`
      ```
      ├── curves
      │   ├── Cargo.toml
      │   ├── README.md
      │   └── src
      │       └── main.rs
      ├── inbreeding
      │   ├── build.nu
      │   ├── Cargo.toml
      │   ├── consts.nu
      │   ├── mod.nu
      │   ├── plot.nu
      │   ├── README.md
      │   ├── run.nu
      │   └── src
      │       ├── environment.rs
      │       ├── main.rs
      │       └── strategy.rs
      ├── rank
      │   ├── Cargo.toml
      │   └── src
      │       └── main.rs
      └── rng
          ├── Cargo.toml
          └── src
              └── main.rs
      ```
      
      - Nushell modules are now located in `./.nushell/`
      
      ## changelog
      apart from the changes to the general structure of the repo:
      - `binary.nu` -> `.nushell/binary.nu`
      - new `cargo bin` command from `.nushell/cargo.nu`
      - `error throw` is now defined in `.nushell/error.nu`
      - main TOML has been greatly simplified because the dependencies of "examples" have been moved to the associated crates
      - the rest is basically the same but in the new structure
      bb626120
Loading