Skip to content
Snippets Groups Projects
  1. Aug 05, 2024
  2. Feb 05, 2024
  3. Dec 14, 2023
    • STEVAN Antoine's avatar
      update the abstract · f9f91cb6
      STEVAN Antoine authored
      f9f91cb6
    • STEVAN Antoine's avatar
      link to the paper in the README · 2bb9d093
      STEVAN Antoine authored
      2bb9d093
    • STEVAN Antoine's avatar
      implement paper reviews (dragoon/pcs-fec-id!161) · 443a4b9c
      STEVAN Antoine authored and DETCHART Jonathan's avatar DETCHART Jonathan committed
      related to 
      - #22
      
      ## description
      some review points to address:
      - [x] **Abstract**: should be self-contained without citing any references.
          - 8e23f751
      - [x] **Importance of the problem**: The introduction could be enhanced to more effectively convey the importance of the research problem. For instance, providing additional context or real-world implications to engage the reader from the outset.
          - fec6a0ba
      - [x] **Contribution section**: The main points and contributions of the paper are not clearly highlighted. It would be beneficial to explicitly outline the key contributions in a dedicated section or subsection to guide readers through the significance of your work.
          - ab8cb7c6
          - bee20327
      - [x] **Protocols motivation**: Currently, the paper lacks a clear demonstration of significant contributions or novel insights to the field. The paper would benefit from including a rationale for the selection of the three commitment schemes (KZG+, aPlonK-PC, Semi-AVID-PC). Were there specific reasons for choosing these schemes over others? It would be helpful to clarify why these schemes were selected, especially considering the various other commitment schemes available.
          - 4f996940
      - [x] **Where is the implementation of the paper?**: Since the primary focus of the paper lies in its implementation, it would be beneficial to make it publicly available.
          - already done in the source => we have just hidden mentions to the authors and the organization for the double-blind submission
      - [x] **Typos**: The manuscript contains several typos that need attention. For example: "any of the curve" should be corrected to "any of the curves." "for some application" should be corrected to "for some applications." "wcomputation" should be corrected to "computation."
          - 0566d16b
      
      i added an "outline" paragraph in 15576c4d to separate it from "contributions" and had to write d530c275 to make the paper fit in 12 pages again.
      443a4b9c
    • STEVAN Antoine's avatar
      complete the documentation (dragoon/pcs-fec-id!160) · 94283358
      STEVAN Antoine authored and DETCHART Jonathan's avatar DETCHART Jonathan committed
      related to
      - #22 
      
      # description
      as per title.
      
      # changelog
      - add a table of content
      - add sections for each of the bigger directories, with commands to open the doc
      - add help to `perf_eval`
      - add some documentation to the crates
      
      👉 see the [readme](https://gitlab.isae-supaero.fr/dragoon/pcs-fec-id/-/tree/documentation#the-structure-of-the-source-base)
      94283358
    • STEVAN Antoine's avatar
      add a license (dragoon/pcs-fec-id!159) · 45d79305
      STEVAN Antoine authored and DETCHART Jonathan's avatar DETCHART Jonathan committed
      related to
      - #22 
      
      ## description
      this MR proposes to add the MIT license with **ISAE-SUPAERO** as the main _copyright holder_.
      45d79305
  4. Dec 07, 2023
  5. Nov 30, 2023
  6. Sep 27, 2023
  7. Sep 21, 2023
  8. Sep 13, 2023
  9. Aug 29, 2023
  10. Aug 03, 2023
  11. Jul 27, 2023
  12. Jul 20, 2023
  13. Jul 17, 2023
  14. Jun 29, 2023
  15. Jun 27, 2023
  16. Jun 26, 2023
  17. Jun 22, 2023
  18. Jun 19, 2023