Skip to content
Snippets Groups Projects

working on the rank algorithm

Merged STEVAN Antoine requested to merge rank into main

tries to address #5 (closed)

changelog

  • the rank.rs example now only returns the rank to stdout
  • two tests have been added
    • one that asserts
      \text{r}(M^T) = \text{r}(M)
    • one that asserts
      \text{r}(M) \leq \min(n, m)
      when
      n
      and
      m
      are the heigth and the width of
      M
      respectively
  • Matrix::rank has been rewritten thanks to ChatGPT, the full prompt can be found in the body of 384d9559 and the algorithm has been refactored and simplified in the following few commits

Note
the two new tests do not pass on e27561bb but do pass on the tip of this MR branch, which indicates that the bugs have been solved

Edited by STEVAN Antoine

Merge request reports

Merge request pipeline #4471 passed

Merge request pipeline passed for 04cae335

Merged by STEVAN AntoineSTEVAN Antoine 1 year ago (Mar 20, 2024 2:25pm UTC)

Loading

Pipeline #4472 passed

Pipeline passed for 1171bc3e on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading