Skip to content
Snippets Groups Projects

fix feature dependencies and imports

Merged STEVAN Antoine requested to merge fix-features into main

in !162 (merged) and !163 (merged), i did only run cargo ... --all-features without checking the individual features...

this MR adds some cargo check --features ... to the Makefile and makes sure the imports make sense when compiling a single feature.

:exclamation: Important

the other notable change here is that kzg::commit has been moved to zk::ark_commit and is re-exported from kzg as kzg::commit.

Edited by STEVAN Antoine

Merge request reports

Merge request pipeline #5740 passed

Merge request pipeline passed for 6740fbe8

Approval is optional

Merged by STEVAN AntoineSTEVAN Antoine 7 months ago (Aug 6, 2024 10:09am UTC)

Merge details

  • Changes merged into main with 15184312 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #5741 passed

Pipeline passed for 15184312 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply