komodo.nu · 4b193d97b784fde335966c868efc4e694213d675 · HEME Clement / Komodo

Forked from Dragoon / Komodo

Source project has a limited visibility.

1 year ago

add runtime checks for `--fec-params` in `komodo prove` (dragoon/komodo!49 ) · c9b8c5da

STEVAN Antoine authored 1 year ago

@n.dissoubray found a bug when not passing `--fec-params` to `komodo prove` where
- `null` cannot be accessed
- invalid keys in `$fec_params` might be accessed and crash the command

this MR adds runtime checks for the type of `--fec-params`, to make sure it's
- non `null`
- has a valid shape

c9b8c5da

History

add runtime checks for `--fec-params` in `komodo prove` (dragoon/komodo!49 )

STEVAN Antoine authored 1 year ago

@n.dissoubray found a bug when not passing `--fec-params` to `komodo prove` where
- `null` cannot be accessed
- invalid keys in `$fec_params` might be accessed and crash the command

this MR adds runtime checks for the type of `--fec-params`, to make sure it's
- non `null`
- has a valid shape

Code owners

Assign users and groups as approvers for specific file changes. Learn more.